Software : : Bootanimplayer 1.0
Posted By: pegasos-sigi2. on 2015/11/21 17:52:21
bootanimplayer

Bootanimplayer 1.0 plays Android bootanimations on your system.
Lot of Android Bootanimations

I include the C - source in the archive, too. You can compile the prog on every system (os4...).
 
  • Priest of the Order of the Butterfly
    Priest of the Order of the Butterfly
    Tcheko
    Joined: 2003/2/25
    Posts: 510
    From: France
    Hello Carsten,

    Just peaked a look at your code.

    unsigned char path[100] = "";
    strcat(path,dir);
    strcat(path,file);

    Please. Avoid such construction. if strlen(dir) + strlen(file) > 99, this code will simply trash what's after path array... The task stack will be messed up and can lead to a crash...

    Do a proper memory allocation for that. A simple AllocVec(strlen(dir)+strlen(file)+1, MEMF_ANY) is good enough for the path array. Don't forget the FreeVec afterward.

    Also, DOS library has functions for concatenating path together that worth a look at imo.

    I have seen other issues here and there that worth fixes too.

    In MuiMinMax method for example:

    msg->MinMaxInfo->MaxWidth += 1280;
    msg->MinMaxInfo->MaxHeight += 1024;

    There is a MUI_MAXMAX define afair. This define allows 'unlimited' max size. Currently, this custom mui class will be limited to 1280x1024 screen resolution.

    Kind regards,

    Tcheko
    Quelque soit le chemin que tu prendras dans la vie, sache que tu auras des ampoules aux pieds.
    -------
    I need to practice my Kung Fu.
  • »2015/11/22 9:24
    Profile Visit Website
  • Order of the Butterfly
    Order of the Butterfly
    pegasos-sigi2
    Joined: 2006/8/31
    Posts: 265
    From:
    Quote:

    Hello Carsten,

    Just peaked a look at your code.

    unsigned char path[100] = "";
    strcat(path,dir);
    strcat(path,file);

    Please. Avoid such construction. if strlen(dir) + strlen(file) > 99, this code will simply trash what's after path array... The task stack will be messed up and can lead to a crash...

    Do a proper memory allocation for that. A simple AllocVec(strlen(dir)+strlen(file)+1, MEMF_ANY) is good enough for the path array. Don't forget the FreeVec afterward.

    Also, DOS library has functions for concatenating path together that worth a look at imo.

    I have seen other issues here and there that worth fixes too.

    In MuiMinMax method for example:

    msg->MinMaxInfo->MaxWidth += 1280;
    msg->MinMaxInfo->MaxHeight += 1024;

    There is a MUI_MAXMAX define afair. This define allows 'unlimited' max size. Currently, this custom mui class will be limited to 1280x1024 screen resolution.

    Kind regards,

    Tcheko


    Don't worry :-)

    unsigned char path[100] = "";
    strcat(path,dir);
    strcat(path,file);



    Your example is from asl.c ? This code is unused here.

    msg->MinMaxInfo->MaxWidth += 1280;
    msg->MinMaxInfo->MaxHeight += 1024;


    I Know ;-) , but i'am lazy ;-)
    Spreedy - The spreedsheet editor of MorphOS
    Calimero - Do you know about the new DTP Program for MorphOS ?
  • »2015/11/22 11:39
    Profile
  • Priest of the Order of the Butterfly
    Priest of the Order of the Butterfly
    Tcheko
    Joined: 2003/2/25
    Posts: 510
    From: France
    Quote:


    ...

    I Know ;-) , but i'am lazy ;-)



    Programming MorphOS isn't *compatible* with lazyness at all. MorphOS isn't some unixoid operating system where you can happily trash ram and don't give a f**k about.

    Publishing sources with such *bad* programming practice won't help people willing to learn programming on MorphOS.

    Also, absolute path in Makefile? WTF?

    Be kind to other people: clean up your code, add comments in english and make a decent makefile without absolute path in.

    Higher quality standard matters. Really.

    [ Edited by Tcheko On 2015/11/22 13:27 ]

    [ Edited by Tcheko On 2015/11/22 13:57 ]
    Quelque soit le chemin que tu prendras dans la vie, sache que tu auras des ampoules aux pieds.
    -------
    I need to practice my Kung Fu.
  • »2015/11/22 12:26
    Profile Visit Website
  • Order of the Butterfly
    Order of the Butterfly
    pegasos-sigi2
    Joined: 2006/8/31
    Posts: 265
    From:
    Quote:

    Quote:


    ...

    I Know ;-) , but i'am lazy ;-)



    Programming MorphOS isn't *compatible* with lazyness at all. MorphOS isn't some unixoid operating system where you can happily trash ram and don't give a f**k about.

    Publishing sources with such *bad* programming practice won't help people willing to learn programming on MorphOS.

    Also, absolute path in Makefile? WTF?

    Be kind to other people: clean up your code, add comments in english and make a decent makefile without absolute path in.

    Higher quality standard matters. Really.

    [ Edited by Tcheko On 2015/11/22 13:27 ]

    [ Edited by Tcheko On 2015/11/22 13:57 ]


    Programming in MorphOS with lazyless is compatible :-) Chill down...please

    Publishing sources with such *bad* programming practice won't help people willing to learn programming on MorphOS.
    Brainfreeze !! :-) It help the most peoples, because they didn't know anything about a lot of things like bootanims ;-)

    Be kind to other people: clean up your code, add comments in english and make a decent makefile without absolute path in.
    We are not in the army... ;-) If yes, i am more skilled in giving army commands like you... ;-)
    Spreedy - The spreedsheet editor of MorphOS
    Calimero - Do you know about the new DTP Program for MorphOS ?
  • »2015/11/22 20:50
    Profile
  • MorphOS Developer
    Krashan
    Joined: 2003/6/11
    Posts: 1107
    From: Białystok...
    @Tcheko: You do it wrong and waste your time. Firstly, there is kind of people considering themselves self-made geniuses. They take their basic mistakes as brillant ideas and simply ignore any constructive criticism. Carsten belongs to this kind. Secondly, if the program works in general, and source code license allows it, just fork it and fix bugs yourself. Then release the fork.
  • »2015/11/22 21:35
    Profile Visit Website
  • Priest of the Order of the Butterfly
    Priest of the Order of the Butterfly
    Tcheko
    Joined: 2003/2/25
    Posts: 510
    From: France
    Quote:

    @Tcheko: You do it wrong and waste your time. Firstly, there is kind of people considering themselves self-made geniuses. They take their basic mistakes as brillant ideas and simply ignore any constructive criticism. Carsten belongs to this kind. Secondly, if the program works in general, and source code license allows it, just fork it and fix bugs yourself. Then release the fork.


    +1 :)
    Quelque soit le chemin que tu prendras dans la vie, sache que tu auras des ampoules aux pieds.
    -------
    I need to practice my Kung Fu.
  • »2015/11/22 23:02
    Profile Visit Website
  • Priest of the Order of the Butterfly
    Priest of the Order of the Butterfly
    Cego
    Joined: 2006/5/28
    Posts: 712
    From: Germany
    can somebody tell me the shell command to run animations? Theres no description anywhere. i only get a "no path found"
    Pegasos II G4 @1.0GHz, 1GB DDR Ram, Radeon 9200Pro, 240GB SSD+160GB HD, MorphOS 3.18, AmigaOS4.1 FE, Debian 8
  • »2015/11/23 0:06
    Profile
  • Order of the Butterfly
    Order of the Butterfly
    igracki
    Joined: 2003/2/25
    Posts: 389
    From: Berlin
    Quote:

    can somebody tell me the shell command to run animations? Theres no description anywhere. i only get a "no path found"


    Code:

    bootanimplayer bootanimation.zip 1
  • »2015/11/23 18:37
    Profile Visit Website
  • Priest of the Order of the Butterfly
    Priest of the Order of the Butterfly
    Cool_amigaN
    Joined: 2011/11/30
    Posts: 746
    From:
    How did you know that the number "1" was needed in order to play the animation?

    Btw, if the the player was running seamlessly (without borders, toolbar) perhaps it could find a purpose for use after boot.
    Amiga gaming Tribute: Watch, rate, comment :)
  • »2015/11/24 10:40
    Profile Visit Website
  • Order of the Butterfly
    Order of the Butterfly
    igracki
    Joined: 2003/2/25
    Posts: 389
    From: Berlin
    According to the name of the argument DELAY (and by looking at the source;)
    it specifies the amount of microseconds between the "parts" of the animation.
    The pictures in the zip archive are seperated into 2 parts, start and end of the animation.
  • »2015/11/24 14:44
    Profile Visit Website
  • Order of the Butterfly
    Order of the Butterfly
    pegasos-sigi2
    Joined: 2006/8/31
    Posts: 265
    From:
    Quote:

    According to the name of the argument DELAY (and by looking at the source;)
    it specifies the amount of microseconds between the "parts" of the animation.
    The pictures in the zip archive are seperated into 2 parts, start and end of the animation.


    bootanimplayer Path/t,Delay/t,Quit/s

    Delay is the Time in microseconds bewegen the pictures.
    Quit quit the prog After playing.
    .
    Spreedy - The spreedsheet editor of MorphOS
    Calimero - Do you know about the new DTP Program for MorphOS ?
  • »2015/11/24 20:41
    Profile
  • Order of the Butterfly
    Order of the Butterfly
    pegasos-sigi2
    Joined: 2006/8/31
    Posts: 265
    From:
    Quote:

    How did you know that the number "1" was needed in order to play the animation?

    Btw, if the the player was running seamlessly (without borders, toolbar) perhaps it could find a purpose for use after boot.


    I have tryed to remove the border, but without sucess. The whole window disapear .
    Spreedy - The spreedsheet editor of MorphOS
    Calimero - Do you know about the new DTP Program for MorphOS ?
  • »2015/11/24 20:54
    Profile
  • Order of the Butterfly
    Order of the Butterfly
    igracki
    Joined: 2003/2/25
    Posts: 389
    From: Berlin
    Quote:

    Quote:

    According to the name of the argument DELAY (and by looking at the source;)
    it specifies the amount of microseconds between the "parts" of the animation.
    The pictures in the zip archive are seperated into 2 parts, start and end of the animation.


    bootanimplayer Path/t,Delay/t,Quit/s

    Delay is the Time in microseconds bewegen the pictures.
    Quit quit the prog After playing.
    .


    I thought that DELAY would delay between each picture, but there is only delay between the parts of the animation!
    Try using 10000 as DELAY.
  • »2015/11/25 12:57
    Profile Visit Website
  • Order of the Butterfly
    Order of the Butterfly
    pegasos-sigi2
    Joined: 2006/8/31
    Posts: 265
    From:
    Quote:

    Quote:

    Quote:

    According to the name of the argument DELAY (and by looking at the source;)
    it specifies the amount of microseconds between the "parts" of the animation.
    The pictures in the zip archive are seperated into 2 parts, start and end of the animation.


    bootanimplayer Path/t,Delay/t,Quit/s

    Delay is the Time in microseconds bewegen the pictures.
    Quit quit the prog After playing.
    .


    I thought that DELAY would delay between each picture, but there is only delay between the parts of the animation!
    Try using 10000 as DELAY.


    10000 µs = 0.01 sec. = Do you can see the difference of 0.01 sec ?
    Spreedy - The spreedsheet editor of MorphOS
    Calimero - Do you know about the new DTP Program for MorphOS ?
  • »2015/11/25 16:57
    Profile
  • Order of the Butterfly
    Order of the Butterfly
    pegasos-sigi2
    Joined: 2006/8/31
    Posts: 265
    From:
    Quote:

    How did you know that the number "1" was needed in order to play the animation?

    Btw, if the the player was running seamlessly (without borders, toolbar) perhaps it could find a purpose for use after boot.


    bootanimplayer 2.0

    Try this: Now it works with screens = no borders and so on..
    Now with anim sound.

    [ Edited by pegasos-sigi2 On 2015/12/6 17:22 ]
    Spreedy - The spreedsheet editor of MorphOS
    Calimero - Do you know about the new DTP Program for MorphOS ?
  • »2015/12/6 16:22
    Profile
  • Order of the Butterfly
    Order of the Butterfly
    igracki
    Joined: 2003/2/25
    Posts: 389
    From: Berlin
    There is still the delay between the two parts of the animation!
    Try this:
    bootanimplayer bootanimation.zip 100000 1280 1024 32 sound

    And btw, yes I can see the difference of 0.01 sec;)
    I'm one of three men in the world which have this power!
    But please, don't spread it around!!!
  • »2015/12/6 18:14
    Profile Visit Website