A source patch aka diff file can be applied to the source with more or less no work.

The problem in this case is that you want to check each changed line, or new bugs or security holes could be introduced. Same goes for binary patches, where you need to trust the patch source.

So unlike source patches from official sites, where people look into it all the time, in this case the diff needs to be checked, even if it applies perfect it could patch unrelated stuff (intentional or unintentional) or even patch the right things wrong (e.g. due copy and paste changes).

So blindly throwing the stuff into the build system is a bad idea.

This is not about this diff in detail, but about all diffs.

Noone has use for a new crash bug that is caused a patched routine, which noone will check again, as it was supposed to be fixed by a diff before.

[ Edited by geit 14.08.2016 - 01:32 ]